-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add display name in heading of catalog tab #1044
Conversation
@katrinan029 If this PR is based on a branch separate from Also note, it looks like this work (likely the parent branch) is based on a prior iteration of the LCM feature before it underwent some clean up / refactoring by Markhors. Would recommend rebasing/syncing with |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## knguyen2/ENT-7591 #1044 +/- ##
=====================================================
- Coverage 83.66% 83.37% -0.29%
=====================================================
Files 444 447 +3
Lines 9462 9509 +47
Branches 1974 1983 +9
=====================================================
+ Hits 7916 7928 +12
- Misses 1503 1534 +31
- Partials 43 47 +4
☔ View full report in Codecov by Sentry. |
Description
The “Catalog” tab needs to have an appropriate heading displayed in the tab’s contents.
Solution
Render the
displayName
from the policydisplay_name
field.Note: This branch is forked from the parent branch #1047 and #1041. The only changes for this PR is in the following files to pass the displayName prop.
src/components/learner-credit-management/BudgetCard-V2.jsx
src/components/learner-credit-management/search/CatalogSearch.jsx
UI
JIRA Ticket
Figma
For all changes
Only if submitting a visual change