Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add display name in heading of catalog tab #1044

Closed
wants to merge 32 commits into from

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Sep 29, 2023

Description

The “Catalog” tab needs to have an appropriate heading displayed in the tab’s contents.

Solution

Render the displayName from the policy display_name field.

Note: This branch is forked from the parent branch #1047 and #1041. The only changes for this PR is in the following files to pass the displayName prop.

  • src/components/learner-credit-management/BudgetCard-V2.jsx
  • src/components/learner-credit-management/search/CatalogSearch.jsx

UI

Screenshot 2023-09-29 at 1 41 22 PM

JIRA Ticket
Figma

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@katrinan029 katrinan029 requested review from adamstankiewicz and a team October 2, 2023 21:30
@adamstankiewicz
Copy link
Member

@katrinan029 If this PR is based on a branch separate from master, can you update the base branch for the PR to the parent branch so only the changes in knguyen/ENT-7592 are shown?

image

Also note, it looks like this work (likely the parent branch) is based on a prior iteration of the LCM feature before it underwent some clean up / refactoring by Markhors. Would recommend rebasing/syncing with master 😄

@katrinan029 katrinan029 changed the base branch from master to knguyen2/ENT-7591 October 27, 2023 16:13
@katrinan029 katrinan029 changed the base branch from knguyen2/ENT-7591 to knguyen/ENT-7591 October 27, 2023 16:22
@katrinan029 katrinan029 changed the base branch from knguyen/ENT-7591 to knguyen2/ENT-7591 October 27, 2023 16:22
@katrinan029 katrinan029 changed the base branch from knguyen2/ENT-7591 to master October 27, 2023 16:25
@katrinan029 katrinan029 changed the base branch from master to knguyen2/ENT-7591 October 27, 2023 16:26
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (5a56945) 83.66% compared to head (d2247fd) 83.37%.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           knguyen2/ENT-7591    #1044      +/-   ##
=====================================================
- Coverage              83.66%   83.37%   -0.29%     
=====================================================
  Files                    444      447       +3     
  Lines                   9462     9509      +47     
  Branches                1974     1983       +9     
=====================================================
+ Hits                    7916     7928      +12     
- Misses                  1503     1534      +31     
- Partials                  43       47       +4     
Files Coverage Δ
...nts/learner-credit-management/cards/CourseCard.jsx 100.00% <ø> (ø)
src/components/settings/data/hooks.js 91.89% <ø> (ø)
src/data/constants/learnerCredit.js 100.00% <100.00%> (ø)
src/data/hooks.js 33.33% <14.28%> (-5.80%) ⬇️
src/components/learner-credit-management/utils.jsx 0.00% <0.00%> (ø)
...mponents/learner-credit-management/algoliaUtils.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from knguyen2/ENT-7591 to master October 27, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants