Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only allow png file type #1316

Merged
merged 2 commits into from
Sep 25, 2024
Merged

feat: only allow png file type #1316

merged 2 commits into from
Sep 25, 2024

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Sep 24, 2024

Description

Updates the accepted file type in the Dropzone to .png only.
https://2u-internal.atlassian.net/browse/ENT-8782

Test plan

  1. npm run start:stage
  2. go to a customer's setting's tab https://localhost.stage.edx.org:1991/adam-autoapplied-enterprise/admin/settings/appearance
  3. upload a jpg image (sample image below) and verify that you see an error alert "Invalid file type, only png images allowed."
    2u

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.60%. Comparing base (932b456) to head (9d162ac).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1316   +/-   ##
=======================================
  Coverage   85.59%   85.60%           
=======================================
  Files         575      575           
  Lines       12678    12678           
  Branches     2683     2689    +6     
=======================================
+ Hits        10852    10853    +1     
+ Misses       1765     1764    -1     
  Partials       61       61           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrinan029 katrinan029 requested a review from a team September 24, 2024 20:29
@katrinan029 katrinan029 merged commit 5ebe94b into master Sep 25, 2024
6 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-8782 branch September 25, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants