feat: only allow png file type (#1316)

openedx · Sep 25, 2024 · 5ebe94b · 5ebe94b
1 parent 932b456
commit 5ebe94b
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/components/settings/SettingsAppearanceTab/index.jsx b/src/components/settings/SettingsAppearanceTab/index.jsx
@@ -145,7 +145,7 @@ export const SettingsAppearanceTab = ({
  }}
  maxSize={512000}
  accept={{
- 'image/*': ['.png'],
+ 'image/png': ['.png'],
  }}
  />
  )}

diff --git a/src/components/settings/SettingsAppearanceTab/tests/SettingsAppearanceTab.test.jsx b/src/components/settings/SettingsAppearanceTab/tests/SettingsAppearanceTab.test.jsx
@@ -104,6 +104,25 @@ describe('Portal Appearance Tab', () => {
  expect(spy).toHaveBeenCalled();
  });
  });
+ test('drops invalid image file type into dropzone', async () => {
+ render(
+ <IntlProvider locale="en">
+ <Provider store={store}>
+ <SettingsAppearanceTab
+ enterpriseId={enterpriseId}
+ enterpriseBranding={enterpriseBranding}
+ updatePortalConfiguration={mockPortalUpdate}
+ />
+ </Provider>
+ </IntlProvider>,
+ );
+ const fakeFile = new File(['hello'], 'hello.jpg', { type: 'image/jpg' });
+ const dropzone = screen.getByRole('presentation', { hidden: true });
+ userEvent.upload(dropzone.firstChild, fakeFile);
+ await waitFor(() => {
+ expect(screen.getByText('Invalid file type, only png images allowed.')).toBeInTheDocument();
+ });
+ });
  test('renders curated theme cards', async () => {
  render(
  <IntlProvider locale="en">