feanil/ubuntu 24.04 #35713
Open
feanil/ubuntu 24.04 #35713
+68
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
feanil
commented
Oct 23, 2024
feanil
commented
- build: Test on ubuntu 24.04
- build: Use a re-usable action to setup mongo.
Rather than doing the install ourselves and needing to keep the debion source URL up-to-date, use a community action to handle installing mongo.
libxmlsec and lxml need to be updated in lockstep and the version we had wouldn't work with Ubuntu 24.04 so unpinning lxml along with libxmlsec to see if that resolves the build and dependency issues.
Run `make upgrade-package package='lxml[html_clean]'` to update lxml and then `make compile-requirements`
feanil
force-pushed
the
feanil/ubuntu-24.04
branch
from
a8e9207
to
b4a8466
Compare
|
@dianakhuang with both xmslec and lxml upgraded it looks like we've got everything passing. Is there any further testing you want to do before we update the testing and merge this? |
This was referenced Oct 24, 2024
|
@feanil I think I'm okay with it as long as you're okay with me panic reverting it if it does break our deploys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.