fix: Don't add x-is-pointer-node attribute to Capa problem XML on paste #35701
+11
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a
problem
component is pasted from a library into a course, we use a hack that adds a "temporary"x-is-pointer-node
attribute to the XML to preventXmlMixin
from looking for more XML data in a place that doesn't exist (the filesystem). However, this somehow causes the temporaryx-is-pointer-node
attribute to end up in the capa problem'sdata
(string) attribute, and authors would see that if they use the advanced editor mode.This PR fixes that by explicitly removing the attribute in cases where it persists.
Supporting information
Relates to openedx/frontend-app-authoring#1377 - this was one of the contributing causes.
Testing instructions
Paste a capa problem component from a library into a course, then open its advanced editor and verify that it doesn't have this attribute in its OLX.
Deadline
Not urgent.