Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE -- testing Meilisearch in tutor core #35689

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

DO NOT MERGE -- testing Meilisearch in tutor core #35689

wants to merge 1 commit into from
+0 −0

Conversation

pomegranited
Copy link
Contributor

@pomegranited pomegranited commented Oct 22, 2024 •
edited
Loading

DO NOT MERGE This PR exists solely to deploy a sandbox for overhangio/tutor#1141.

Part of: openedx/modular-learning#236

Settings

# https://github.com/overhangio/tutor-forum/pull/48/files#diff-0d2d2c5ee050cc46953dd441dc0d4182751734361acf18294183d2928664418eR23-R31
EDX_PLATFORM_REPOSITORY: https://github.com/edly-io/edx-platform.git
EDX_PLATFORM_VERSION: edly/forumv2

OPENEDX_COMMON_VERSION: master

# https://github.com/openedx/edx-search/pull/162
OPENEDX_EXTRA_PIP_REQUIREMENTS:
- git+https://github.com/openedx/edx-search.git@master

# Grove expects this variable to be defined
RUN_ELASTICSEARCH: false

# tutor-grove v2 doesn't make an image, so have to omit it from the default
GROVE_IMAGE_BUILD_CONFIG:
  mfe:
    DOCKER_IMAGE_VAR: TUTOR_MFE_DOCKER_IMAGE
  openedx:
    DOCKER_IMAGE_VAR: TUTOR_DOCKER_IMAGE_OPENEDX

PLUGINS:
- mfe
- grove
- forum
- s3
PLUGIN_INDEXES:
- https://overhang.io/tutor/main

ENABLE_HTTPS: true
ENABLE_WEB_PROXY: false
S3_STORAGE_BUCKET: "edward-murow"

# Temporarily required to work around issue in tutor-contrib-grove since Tutor no longer defines RUN_LMS/RUN_CMS:
RUN_CMS: true
RUN_LMS: true

Tutor requirements

# https://github.com/overhangio/tutor/pull/1141
# + https://github.com/overhangio/tutor/pull/1143
git+https://github.com/open-craft/tutor.git@jill/regisb/meilisearch
# https://github.com/overhangio/tutor-forum/pull/48
git+https://github.com/overhangio/tutor-forum.git@regisb/forumv2
# https://github.com/overhangio/tutor-mfe/pull/228
git+https://github.com/open-craft/tutor-mfe.git@jill/mfe-enable-meilisearch

# Grove / Harmony
git+https://github.com/open-craft/tutor-contrib-s3.git@main
git+https://gitlab.com/opencraft/dev/tutor-contrib-grove.git@main
git+https://github.com/openedx/[email protected]#egg=tutor-contrib-harmony-plugin&subdirectory=tutor-contrib-harmony-plugin

@openedx-webhooks
Copy link

openedx-webhooks commented Oct 22, 2024 •
edited
Loading

Thanks for the pull request, @pomegranited!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 22, 2024
@pomegranited pomegranited added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Oct 22, 2024
@pomegranited pomegranited mentioned this pull request Oct 22, 2024
Open
@pomegranited pomegranited marked this pull request as ready for review October 22, 2024 02:55
@pomegranited pomegranited marked this pull request as draft October 22, 2024 04:17
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@pomegranited
Copy link
Contributor Author

Status update:

As you can see, the sandbox deployment keeps failing, The issue is with Grove's list of images it wants to build, which includes forum, but the new forum v2 doesn't have an image. Working on it..

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@pomegranited pomegranited removed the create-sandbox open-craft-grove should create a sandbox environment from this PR label Oct 24, 2024
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Contributions
Status: Waiting on Author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pomegranited @openedx-webhooks @open-craft-grove