Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop Python 3.8 & Add Support for Python 3.12 #35585

Closed
wants to merge 3 commits into from

Conversation

merelcht
Copy link

@merelcht merelcht commented Oct 3, 2024

Description

Follow and complete all of the following steps for the issue to be marked as done.

  • Update the tox.ini, setup.py, setup.cfg, or pyproject.toml to remove Python 3.8 and add support for Python 3.12.
  • Ensure GitHub Actions workflows, including the CI matrix, are updated to reflect the supported Python versions (3.11, and 3.12).
  • Adjust any testing or build configurations to ensure compatibility with Python 3.12.
  • Remove references to Python versions earlier than 3.11 from all relevant configuration files.
  • Run all tests and verify they pass in the CI with the updated versions.
  • Add a CHANGELOG entry: “Dropped support for Python 3.8 and added support for Python 3.12.”
  • Bump the package version and release a new version on GitHub & PyPI (where applicable).

Supporting information

Addresses #35457

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 3, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @merelcht!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@merelcht merelcht changed the title Drop Python 3.8 & Add Support for Python 3.12 chore: drop Python 3.8 & Add Support for Python 3.12 Oct 3, 2024
@merelcht
Copy link
Author

merelcht commented Oct 8, 2024

@irtazaakram I've had a stab at solving #35457, but I need some help getting the tests running. The CI builds need to be approved. I had some trouble running the tests locally. Do you have any guidance on how to set them up and run locally?

@irtazaakram
Copy link
Member

@merelcht Thanks for taking a crack at #35457! To get the tests running locally, you'll need to install edx-platform via Tutor. You can find the setup instructions here: Tutor Development Guide. Once you're set up, you can follow this guide for running the tests locally: Running edx-platform Unit Tests.

If you're just getting started, I recommend beginning with the packages listed here: Python 3.12 Support Tracking, since the edx-platform depends on most, if not all, of them being compatible with Python 3.12 first.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 10, 2024
@merelcht
Copy link
Author

I'm closing this because I'm having trouble getting everything installed properly. I don't know when I'll have time again to investigate what's going on.

@merelcht merelcht closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs test run Author's first PR to this repository, awaiting test authorization from Axim open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants