Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display tags on the Unit page in Studio (feature-flagged) - Take 2 [FC-0036] #33761

Merged

Conversation

ChrisChV
Copy link
Contributor

Description

This adds:

  • a new container subview to show the list of tags of a unit.
  • the "Manage tags" menu item on the component menu.
    Both are under the new_studio_mfe.use_tagging_taxonomy_list_page flag.

image
image

Supporting information

Testing instructions

  • Turn on the new_studio_mfe.use_tagging_taxonomy_list_page flag on studio.
  • Run taxonomy-sample-data script to create sample data.
  • On lms shell run paver update_assets. You need to clear the cache of your browser or use an incognito session
  • Make sure you have the frontend-app-course-authoring repo cloned and checkout the branch of this PR [FC-0036] feat: Add ContentTagsDrawer widget frontend-app-authoring#654
  • Go to a new created unit and check the tag list.
  • Click on "Manage tags" and check that opens the drawer.
  • Open the menu of a component and click on "Manage tags". Check that opens the drawer
  • Turn off the new_studio_mfe.use_tagging_taxonomy_list_page flag on studio.
  • Return to the unit page and verify that the tag list and the "Manage tags" menu item not shown

Additional info

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 21, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@open-craft-grove
Copy link

Sandbox deploy request received. Deployment will start soon.

@open-craft-grove
Copy link

Sandbox deployment started.

@ChrisChV
Copy link
Contributor Author

@bradenmacdonald This is ready. The fix is on 507eb51 CC @rgraber

@open-craft-grove
Copy link

Sandbox update request received. Deployment will start soon.

@open-craft-grove
Copy link

Sandbox deployment successful.

Sandbox LMS is available at pr-33761-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33761-139931.staging.do.opencraft.hosting

@open-craft-grove
Copy link

Sandbox deployment started.

@open-craft-grove
Copy link

Sandbox deployment successful.

Sandbox LMS is available at pr-33761-139931.staging.do.opencraft.hosting
Sandbox Studio is available at studio.pr-33761-139931.staging.do.opencraft.hosting

Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: quick smoke test in Studio
  • I read through the code - same as prior PR with minor fix for trailing comma issue
  • I checked for accessibility issues
  • Includes documentation

@bradenmacdonald bradenmacdonald changed the title Chris/fal 3527 tags on unit page Display tags on the Unit page in Studio (feature-flagged) - Take 2 [FC-0036] Nov 21, 2023
@bradenmacdonald bradenmacdonald added the FC Relates to an Axim Funded Contribution project label Nov 21, 2023
@bradenmacdonald bradenmacdonald merged commit f72710e into openedx:master Nov 21, 2023
64 checks passed
@bradenmacdonald bradenmacdonald deleted the chris/FAL-3527-tags-on-unit-page branch November 21, 2023 20:12
@openedx-webhooks
Copy link

@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@open-craft-grove
Copy link

Sandbox update request received. Deployment will start soon.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Tagging] Access unit/component tags from the Unit page
5 participants