Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update content_tagging for compatibility with new openedx-learning [FC-0036] #33553

Merged

Conversation

bradenmacdonald
Copy link
Contributor

@bradenmacdonald bradenmacdonald commented Oct 20, 2023

Description

This updates edx-platform to be compatible with the changes I made to how tags are retrieved from taxonomies in openedx/openedx-learning#92 . The actual changes required are trivial, just updating one test.

Supporting information

See linked PR for details of this change, which makes the APIs for retrieving tags from a taxonomy much more flexible and optimized.

Testing instructions

Just run the tests.

Deadline

None

Other information

  • Version bump needs to happen first in openedx-learning

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 20, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @bradenmacdonald! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@bradenmacdonald bradenmacdonald added the FC Relates to an Axim Funded Contribution project label Oct 20, 2023
@bradenmacdonald bradenmacdonald force-pushed the braden/update-new-get-filtered-tags branch 2 times, most recently from 729d65e to 6c9a874 Compare October 26, 2023 17:37
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this: checked that the tests are passing
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

@bradenmacdonald bradenmacdonald merged commit e6e124b into openedx:master Oct 27, 2023
64 checks passed
@bradenmacdonald bradenmacdonald deleted the braden/update-new-get-filtered-tags branch October 27, 2023 17:06
@openedx-webhooks
Copy link

@bradenmacdonald 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants