feat: working library source xblock #33057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YT: https://youtrack.raccoongang.com/issue/EDX_BLND_CLI-87 - V2 libraries are available for selection in the Random Block edit modal; - selected V2 library blocks are copied to the modulestore and saved as children of the Random Block; - V2 library version validation works the same as for the V1 libraries (with possibility to update block with the latest version); - filtering by problem type can't be done for V2 the same as for V1 because the v2 library problems are not divided by types; - unit tests added/updated.
…e top default level
YT: https://youtrack.raccoongang.com/issue/EDX_BLND_CLI-87 - V2 libraries are available for selection in the Random Block edit modal; - selected V2 library blocks are copied to the modulestore and saved as children of the Random Block; - V2 library version validation works the same as for the V1 libraries (with possibility to update block with the latest version); - filtering by problem type can't be done for V2 the same as for V1 because the v2 library problems are not divided by types; - unit tests added/updated.
…e top default level
…edx-platform into feat--Working-Library-Source-Xblock
connorhaugh
changed the title
| self.assertEqual(self.problem_in_course.location, self.lc_block.children[0]) | ||
| self.assertEqual(self.problem_in_course.display_name, self.original_display_name) | ||
| # and the block has changed too. | ||
| self.assertEqual(len(self.lc_block.children), 2) |
There was a problem hiding this comment.
This tests is no longer testing what it says in the docstring. I think it's important to preserve a test for that ("if a library content block is pinned to some library version and duplicated, the new block is pinned to the same version, and the children are NOT updated to the newest version")
|
@bradenmacdonald thanks for the precise feedback I'll take all of this into consideration. A good amount of this work is assembling pieces of other's past work, but hopefully your approach will allow me to put in quick fixes for many of these. |
kdmccormick
reviewed
Sep 8, 2023
…edx-platform into feat--Working-Library-Source-Xblock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An updated feature branch containing:
https://github.com/openedx/edx-platform/pull/31319/files
#30895
#30801
#30800
TODO: