Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libify api fields #3174

Open
wants to merge 5 commits into
base: filter-by-org-badge
Choose a base branch
from
Open

Libify api fields #3174

wants to merge 5 commits into from

Conversation

magopian
Copy link
Contributor

This is based on PR #3155

Add docstrings, comments and tests for the "new system" from @ThibaudDauce.

@magopian magopian changed the base branch from master to filter-by-org-badge October 22, 2024 16:35
@magopian magopian force-pushed the libify-api_fields branch 2 times, most recently from 5a40947 to 991b1d1 Compare October 28, 2024 11:21
Copy link
Contributor

@bolinocroustibat bolinocroustibat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Type hints, comments and good namings always rejoice me :)

@magopian magopian changed the base branch from filter-by-org-badge to master November 4, 2024 15:43
@magopian magopian changed the base branch from master to filter-by-org-badge November 4, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants