Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request accept buttons into dropdown #16987

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ncounter
Copy link
Contributor

@ncounter ncounter commented Oct 21, 2024

Depends on #16960

Only the last commit contains this relevant PR change

The proposal is about keeping separated all the different decision actions, but grouping the accept request ones. Accepting request can be made like:

  1. Accept
  2. 1+ make the submitter a maintainer of the target project/package
  3. 1+ forward to projects
  4. 1+2+3 (Accept + make maintainer + forward)

Due to the fact that the forward can be submitted to multiple choices, they requires checkboxes to be visible and selectable, thus the separated dropdown for the accept+forwards options

image

image

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Things related to the OBS RoR app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants