Merge pull request #16808 from kastakhov/anon-ldap

Fix anonymous bind to LDAP server

src/api/app/models/user_ldap_strategy.rb

@@ -174,6 +174,10 @@ def try_ldap_con(server, user_name, password)
       # implicitly turn array into string
       user_name = [user_name].flatten.join
 
+      # LDAP bind quietly dies when user_name or password is nil
+      # password can be nil in case of passwordless authentication or anonymous bind
+      password ||= ''
+
       Rails.logger.debug { "UserLdapStrategy: Connecting to server '#{server}' as user '#{user_name}'" }
       port = ldap_port
 
@@ -191,7 +195,7 @@ def try_ldap_con(server, user_name, password)
         Rails.logger.info("UserLdapStrategy: Failed to bind as user '#{user_name}': #{con.err2string(con.err)}")
         return
       end
-      Rails.logger.debug { "UserLdapStrategy: Bound as #{user_name}" }
+      Rails.logger.debug { "UserLdapStrategy: Bound as '#{user_name}'" }
       con
     end