Feature/remove django choices #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
SilviaAmAm
approved these changes
Sep 6, 2023
joeribekker
requested changes
Sep 11, 2023
| @@ -1531,7 +1531,7 @@ def test_full_update_gebruiksrechten(self): | |||
|
|
|||
| # Create gebruiksrechten | |||
| gebruiksrechten_data = { | |||
| "informatieobject": f"https://testserver/api/v1/documenten/{document.uuid}", | |||
There was a problem hiding this comment.
Why was this changed? I prefer not to have specific URLs.
There was a problem hiding this comment.
These "https://testserver/..." urls fail when CI runs with turned on URL mapping, because this pattern is not known for set upt UrlMapping data.
TBH I don't know why it worked before, but other Gebruiksrechten tests have "https://drc.utrechtproeftuin.nl/..." urls so I just adjusted these two tests to match
There was a problem hiding this comment.
Ok, then this will be moved to a new issue.
joeribekker
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.