Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[outreachy] Resizing of cards #5421

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

DIANAAJAMBO
Copy link

@DIANAAJAMBO DIANAAJAMBO commented Oct 16, 2024

@svrnm , This task resolves issue #5335 and below are the changes that i made to this effect.

Card Layout

  • Resized cards to fit better within the available space.
  • Replaced text next to icons with tooltips for a cleaner look.
  • Adjusted font size to match the new card dimensions.

Link Styling

  • Removed underlines from the links for a cleaner design.
  • Applied different colors to titles and authors for clear visual differentiation.

Card Interactivity

  • Added hover effects to make the cards interactive and engaging for users.

Responsive Design

  • Made the layout mobile-friendly by ensuring the cards are responsive on various devices, including tablets, computers, and phones.

Card Identification

  • Kept the original border colors to maintain card identification but introduced unique hover effects for each card for better user experience.

Testing

  • Verified responsiveness and functionality across multiple devices to ensure the layout works well on all screen sizes.

Tools

  • Used Bootstrap classes such as those for griding, typography, tooltips and also custom css.

Screenshot 2024-10-17 001654
Screenshot 2024-10-17 001748

@DIANAAJAMBO DIANAAJAMBO requested a review from a team as a code owner October 16, 2024 21:23
Copy link

linux-foundation-easycla bot commented Oct 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@svrnm svrnm changed the title Resizing of cards [outreachy] Resizing of cards Oct 17, 2024
@svrnm svrnm added enhancement New feature or request registry outreachy Issues for Outreachy Participants labels Oct 17, 2024
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks really good, thank you, please take a look into my comments, especially the one about formatting, otherwise I have a hard time to see what you have changed and what was there previously

Comment on lines 51 to 62
.description{
font-size: 0.9rem;
}

.quickInstall{
margin-left: 1%;
}

.list-group-item{
padding-left: 0px;
padding-right: 0px;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure that these CSS properties are only valid for the registry.

Copy link
Author

@DIANAAJAMBO DIANAAJAMBO Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svrnm I've modified the above properties and replaced them with more specific class names that are unique to the registry as seen below.

.narrative {
font-size: 0.9rem;
}

.quick-setup {
margin-left: 1%;
}

.item-specs {
padding-left: 0px;
padding-right: 0px;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have a lot of unrelated changes to the format, that you need to revert, otherwise it is hard for me to identify what is new. If you run npm run fix:format locally they will hopefully be reverted, otherwise you may need to take a look manually

Copy link
Author

@DIANAAJAMBO DIANAAJAMBO Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svrnm , I have run the command and it made changes to the registry file specifically. It had to do with the spacing between the classes and the curly brackets. Hopefully it was resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request outreachy Issues for Outreachy Participants registry
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants