Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use codecov token when uploading reports #5053

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Oct 8, 2024

Which problem is this PR solving?

Noticed that all the PR states that the coverage from main is behind. Looks like on main the permissions are not enough to create a new main commit in codecov.

So I'm now passing the token to see if that makes a difference. This is what the Go SIG does:
https://github.com/open-telemetry/opentelemetry-go/blob/8fbaa970843f0899228bc19c1e45a31f5a5bb73e/.github/workflows/ci.yml#L124-L130

See:

I've noticed the same happening on contrib, where we're hundreds of commits behind. We'll have to do the same there.

@pichlermarc pichlermarc requested a review from a team as a code owner October 8, 2024 12:24
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.27%. Comparing base (f8ab559) to head (754bbe2).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5053      +/-   ##
==========================================
- Coverage   93.39%   93.27%   -0.13%     
==========================================
  Files          46      317     +271     
  Lines         712     8194    +7482     
  Branches      120     1640    +1520     
==========================================
+ Hits          665     7643    +6978     
- Misses         47      551     +504     

see 266 files with indirect coverage changes

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Do you know that this repo has a CODECOV_TOKEN secret set? Or perhaps that's at the org level.

@pichlermarc
Copy link
Member Author

LGTM. Do you know that this repo has a CODECOV_TOKEN secret set? Or perhaps that's at the org level.

yep, i checked before opening this PR. It's defined at the org level and inherited by this repo 🙂

@pichlermarc pichlermarc added this pull request to the merge queue Oct 9, 2024
Merged via the queue into open-telemetry:main with commit 859c0ef Oct 9, 2024
21 of 22 checks passed
@pichlermarc pichlermarc deleted the fix/codecov-upload branch October 9, 2024 08:11
Annosha pushed a commit to Annosha/opentelemetry-js that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants