Finch: Sets the trace status to error on any 5xx response

instrumentation/opentelemetry_finch/lib/opentelemetry_finch.ex

@@ -67,6 +67,10 @@ defmodule OpentelemetryFinch do
  kind: :client
  })
 
+ if status >= 500 && status < 600 do
+ OpenTelemetry.Span.set_status(s, OpenTelemetry.status(:error))
+ end
+
  if meta.result |> elem(0) == :error do
  OpenTelemetry.Span.set_status(
  s,

instrumentation/opentelemetry_finch/test/opentelemetry_finch_test.exs

@@ -51,7 +51,7 @@ defmodule OpentelemetryFinchTest do
  } = :otel_attributes.map(attributes)
  end
 
- test "records span on requests failed", %{bypass: _} do
+ test "records span on requests failed" do
  OpentelemetryFinch.setup()
 
  _conn = start_supervised!({Finch, name: HttpFinch})
@@ -75,5 +75,33 @@ defmodule OpentelemetryFinchTest do
  } = :otel_attributes.map(attributes)
  end
 
+ # https://opentelemetry.io/docs/specs/semconv/http/http-spans/#status
+ # > For HTTP status codes in the 5xx range, as well as any other code the client failed to interpret, span status MUST be set to Error.
+ test "records span on 500 error from server", %{bypass: bypass} do
+ Bypass.expect(bypass, fn conn -> Plug.Conn.resp(conn, 500, "Internal Server Error") end)
+
+ OpentelemetryFinch.setup()
+
+ _conn = start_supervised!({Finch, name: HttpFinch})
+
+ {:ok, _} = Finch.build(:get, endpoint_url(bypass.port)) |> Finch.request(HttpFinch)
+
+ assert_receive {:span,
+ span(
+ name: "HTTP GET",
+ kind: :client,
+ status: {:status, :error, ""},
+ attributes: attributes
+ )}
+
+ assert %{
+ "net.peer.name": "localhost",
+ "http.method": "GET",
+ "http.target": "/",
+ "http.scheme": :http,
+ "http.status_code": 500
+ } = :otel_attributes.map(attributes)
+ end
+
  defp endpoint_url(port), do: "http://localhost:#{port}/"
 end