Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Oban plugin handler and fix error handling #195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve Oban plugin handler and fix error handling #195

wants to merge 1 commit into from

Commits on Aug 21, 2023

  1. Improve Oban plugin handler and fix error handling 

    The main purpose of this patch is to introduce plugin aware attributes -
mostly counts of processed jobs.

Plugins cover all the offerings of Oban 2.15 and Oban Pro 1.0, the
current versions at time of writing.

While testing this in a real app, I've noticed issues with exception
handlers for plugin. Decided to slip in this patch changes to both job
and plugin event handlers to rely on standard :telemetry.span/3
attributes instead of :error key (which seems like an artifact of
earlier versions).
    @andrewhr
    andrewhr committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    9238a0e View commit details
    Browse the repository at this point in the history