[Instrumentation.AWS] Move adding request and response info to AWSTracingPipelineHandler #2137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2108
Changes
This pull request addresses issue #2108 where AWS SDK request info were not being applied as expected. The logic for adding these info has been moved to the
AWSTracingPipelineHandler
which is executed early in the AWS SDK pipeline in order to manipulate outgoing requests objects before they are serialized.I didn't add additional tests here since we will need to examine the request at a specific part of the AWS request pipeline to validate these changes, but I ran the same code that was provided in the issue and the
traceparent
was sent and received properlyMerge requirement checklist
CHANGELOG.md
files updated for non-trivial changes