Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/FSRS-5 #197

Merged
merged 15 commits into from
Jul 14, 2024
Merged

Feat/FSRS-5 #197

merged 15 commits into from
Jul 14, 2024

Conversation

L-M-Sherlock
Copy link
Member

No description provided.

@L-M-Sherlock L-M-Sherlock added the enhancement New feature or request label Jul 11, 2024
AlexErrant
AlexErrant reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@AlexErrant AlexErrant left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/open-spaced-repetition/fsrs-rs/pull/197/files#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542

Just wondering; should we synchronize versions across FSRS? Like, could this be 5.0.0?

@L-M-Sherlock
Copy link
Member Author

Just wondering; should we synchronize versions across FSRS? Like, could this be 5.0.0?

There are too many packages of FSRS implementation, and some of them are not maintained by myself. So I think it's unnecessary to synchronize versions across FSRS.

@user1823
Copy link
Contributor

user1823 commented Jul 12, 2024 •
edited
Loading

@L-M-Sherlock, can you summarize the changes in FSRS 5 as compared to FSRS 4.5? I believe that it will be useful for the reviewers of this PR as well as for future reference.

@L-M-Sherlock
Copy link
Member Author

can you summarize the changes in FSRS 5 as compared to FSRS 4.5

In short, it considers the short-term schedule, and changes the formula to calculate the initial diffculty.

For details, see https://github.com/open-spaced-repetition/fsrs4anki/wiki/The-Algorithm#fsrs-5-draft

@L-M-Sherlock L-M-Sherlock enabled auto-merge (squash) July 14, 2024 12:49
@L-M-Sherlock L-M-Sherlock merged commit c9b9254 into main Jul 14, 2024
3 checks passed
@L-M-Sherlock L-M-Sherlock deleted the Feat/FSRS-5 branch July 14, 2024 12:49
@L-M-Sherlock
Copy link
Member Author

@AlexErrant https://github.com/open-spaced-repetition/fsrs-rs/actions/runs/9928079913/job/27423861989 The merge action failed. Could you help me check it?

@AlexErrant
Copy link
Member

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asukaminato0721 asukaminato0721 asukaminato0721 left review comments

@AlexErrant AlexErrant AlexErrant left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@L-M-Sherlock @user1823 @AlexErrant @asukaminato0721