Added support for tcpdump command attachment #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matsvanmolle I believe tcpdump is not a command wrapper, as you cannot give it a specific command in its own command line. It is more of a CommandAttachment in benchkit methodology (something that you run in parallel with your actual benchmark command). Could you update your patch to comply to that? |
Merged
this is an initial convertion of the tcpdump wrapper to an attachment. Not tested (for now) Signed-off-by: Mats Van Molle <[email protected]>
matsvanmolle
changed the title
|
Hi @matsvanmolle let me know once this is ready. You can also remove the "draft" status once you consider it is ready to be reviewed and integrated. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.