Add: ftrace support #130
Add: ftrace support #130
Conversation
Signed-off-by: TryAngle <[email protected]>
Signed-off-by: TryAngle <[email protected]>
|
Adding ftrace support is a great idea! |
yes it is, android is just the target of main concern right now, so tested it with it. I will make it into a module once it works and split the test between android and linux (and maybe harmony)
yes, it's a mix between trying out and adding the module. Once the test works, it's moved into a module. |
tests/test_android_ftrace.py
Outdated
| event_stack = [] | ||
|
|
||
| # TODO: fix this parsing, it seems to be incorrect | ||
| with open(file, "r") as f: |
There was a problem hiding this comment.
We should be able to use the perfetto trace processor. https://perfetto.dev/docs/analysis/trace-processor-python
Did you try it out already and ran into issues?
There was a problem hiding this comment.
no i did not, but this looks like a very promising idea, I'll try it out.
Signed-off-by: TryAngle <[email protected]>
|
@jschwe @apaolillo the perfetto TraceProcessor works and allows easy event filtering via SQL. Also where should the platform abstraction take place? Right now the comm layer is not working for android and harmony, and if we assume it was, where would the current functions like: |
| # Returns: | ||
| # str: adb identifier of current device. | ||
| # """ | ||
| # return _identifier_from(ip_addr=self._ip, port=self._port) |
There was a problem hiding this comment.
Why can't this just return self.identifier?
Signed-off-by: TryAngle <[email protected]>
@apaolillo @jschwe
this pull request's intention is to add ftrace parsing support to benchkit.
it's not complete yet, I seem to have issues with the parsing of the events.
I also had the issue of instantiating adb bridge with my local android device that does not have an IP Address but a small identifier code (similar to hdc right now?) do I miss something? For a quick workaround I removed ip_addr and port from AndroidDebugBridge and added identifier to it (this may cause issues for other things?, at least it works for my experimentation) I also added a from_device constructor for the AndroidDebugBridge, very similar to HDC.