Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix generate tls cert insecure algorithm SHA1-RSA #2

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix generate tls cert insecure algorithm SHA1-RSA #2

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e31c1d7
fix generate tls cert script use -sha256
yanhu-cheng-20230331 Sep 6, 2022
da1e6fc
fix would violate PodSecurity restricted:latest: unrestricted capabil…
yanhu-cheng-20230331 Sep 6, 2022
ffed5cb
fix yaml format
yanhu-cheng-20230331 Oct 10, 2022
b056709
Merge branch 'main' into main
redwarn Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/external-data-provider/templates/external-data-provider-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ spec:
mountPath: /tmp/gatekeeper
readOnly: true
{{- end }}
securityContext:
{{- toYaml .Values.securityContext | nindent 12 }}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove new line

restartPolicy: Always
nodeSelector:
kubernetes.io/os: linux
Expand Down
9 changes: 9 additions & 0 deletions charts/external-data-provider/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,12 @@ provider:
enabled: true
caBundle: ""
skipVerify: false

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove new line

securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
runAsNonRoot: true
seccompProfile:
type: RuntimeDefault
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add newline

2 changes: 1 addition & 1 deletion scripts/generate-tls-cert.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ generate() {
echo "Generating server key and certificate for external-data-provider..."
openssl genrsa -out tls.key 2048
openssl req -newkey rsa:2048 -nodes -keyout tls.key -subj "/CN=external-data-provider.${NAMESPACE}" -out server.csr
openssl x509 -req -extfile <(printf "subjectAltName=DNS:external-data-provider.%s" "${NAMESPACE}") -days 1 -in server.csr -CA ca.crt -CAkey ca.key -CAcreateserial -out tls.crt
openssl x509 -req -extfile <(printf "subjectAltName=DNS:external-data-provider.%s" "${NAMESPACE}") -days 1 -sha256 -in server.csr -CA ca.crt -CAkey ca.key -CAcreateserial -out tls.crt
}

mkdir -p "${REPO_ROOT}/certs"
Expand Down