Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update buildkit and allow dependabot #911

Merged

Conversation

erpel
Copy link
Contributor

@erpel erpel commented Feb 1, 2024

Updates the buildkit dependency to get rid of CVE scanner findings:

Additionally add buildkit to the allowed dependencies in dependabot config.

Updates the buildkit dependency to get rid of CVE scanner findings:
- CVE-2024-23651
- CVE-2024-23652
- CVE-2024-23653
- CVE-2024-23650

Additionally add buildkit to the allowed dependencies in
dependabot config.

Signed-off-by: Philipp Erbelding <[email protected]>
@robmonct
Copy link
Contributor

robmonct commented Feb 5, 2024

The moby/buildkit bump provokes an error into the release:

⨯ release failed after 47s                 
error=failed to build for linux_amd64_v1: exit status 1: # github.com/moby/buildkit/frontend/dockerfile/instructions
Error: ../../../go/pkg/mod/github.com/moby/[email protected]/frontend/dockerfile/instructions/parse.go:592:15: healthcheck.StartInterval undefined (type container.HealthConfig has no field or method StartInterval)

I've been trying to solve, but I can't find the way to configure that healthcheck.StartInterval to be picked up by moby/buildkit

UPDATE:
After some hours, it started to work. I don't know the reason to be honest.

Copy link
Member

@jalseth jalseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think conftest uses the vulnerable code path, but including the patch doesn't hurt. Thanks for the PR.

@jalseth jalseth merged commit 15019c2 into open-policy-agent:master Feb 7, 2024
7 checks passed
@erpel erpel deleted the buildkit_update_and_dependabot branch February 8, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants