Skip to content

Commit

Permalink
Merge pull request #56 from open-formulieren/feature/op-24-product-pr…
Browse files Browse the repository at this point in the history
…ice-component

[maykinmedia/open-producten#24] remove product attribute from Product
  • Loading branch information
sergei-maertens authored Oct 16, 2024
2 parents 63eac59 + 12584bd commit f4d3d00
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion src/formio/components/productPrice.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,4 @@ export type ProductPriceInputSchema = InputComponentSchema<never, Validator, Tra
export interface ProductPriceComponentSchema
extends Omit<ProductPriceInputSchema, 'hideLabel' | 'disabled'> {
type: 'productPrice';
product: string;
}
4 changes: 0 additions & 4 deletions test-d/formio/components/productPrice.test-d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ expectAssignable<ProductPriceComponentSchema>({
type: 'productPrice',
key: 'aProductPrice',
label: 'A Product Price',
product: '123'
} as const);

// different component type
Expand All @@ -22,7 +21,6 @@ expectNotAssignable<ProductPriceComponentSchema>({
type: 'productPrice',
key: 'aProductPrice',
label: 'A Product Price',
product: '123',
hideLabel: true,
} as const);

Expand All @@ -32,7 +30,6 @@ expectNotAssignable<ProductPriceComponentSchema>({
type: 'productPrice',
key: 'aProductPrice',
label: 'A Product Price',
product: '123',
defaultValue: 1,
});

Expand All @@ -43,7 +40,6 @@ expectAssignable<ProductPriceComponentSchema>({
// basic tab in builder form
key: 'aProductPrice',
label: 'A Product Price',
product: '123',
description: 'Sample description',
tooltip: 'A tooltip',
showInSummary: true,
Expand Down

0 comments on commit f4d3d00

Please sign in to comment.