Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [#4600] Perform reload on language change #4741

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

robinmolen
Copy link
Contributor

Closes #4600

Changes

Triggering a page reload after language change, using the new onLanguageChange property on the sdk form object. This PR requires [open-formulieren/open-forms-sdk#715]

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@robinmolen robinmolen linked an issue Oct 8, 2024 that may be closed by this pull request
@robinmolen robinmolen added the needs-backport Fix must be backported to stable release branch label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (3a310db) to head (7d3482b).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4741   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         746      746           
  Lines       25185    25185           
  Branches     3312     3312           
=======================================
  Hits        24320    24320           
  Misses        601      601           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinmolen robinmolen force-pushed the issue/4600-reload-page-on-language-change branch from 356318f to 7d3482b Compare October 8, 2024 15:09
@sergei-maertens sergei-maertens merged commit ae24371 into master Oct 8, 2024
23 of 25 checks passed
@sergei-maertens sergei-maertens deleted the issue/4600-reload-page-on-language-change branch October 8, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the language doesn't properly translate some links
2 participants