Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[open-formulieren/open-forms#4600] Language switch now triggers an page reload #715

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/sdk.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ class OpenForm {
languageSelectorTarget,
displayComponents = {}, // TODO: document as unstable API
useHashRouting = false,
onLanguageChange,
} = opts;

this.targetNode = targetNode;
Expand All @@ -79,6 +80,7 @@ class OpenForm {
this.lang = lang;
this.displayComponents = {...defaultDisplayComponents, ...displayComponents};
this.useHashRouting = useHashRouting;
this.onLanguageChange = typeof onLanguageChange === 'function' ? onLanguageChange : undefined;

switch (typeof languageSelectorTarget) {
case 'string': {
Expand Down Expand Up @@ -173,6 +175,10 @@ class OpenForm {
}

async onLanguageChangeDone(newLanguagecode) {
if (this.onLanguageChange) {
this.onLanguageChange(newLanguagecode);
return;
}
this.formObject = await get(this.url);
this.render();
}
Expand Down
28 changes: 28 additions & 0 deletions src/sdk.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,34 @@ describe('OpenForm', () => {
expect(within(formRoot).getAllByText('English version').length).toBeGreaterThan(0);
});

it('should call the onLanguageChange callback on language change', async () => {
mswServer.use(...apiMocks);
const formRoot = document.createElement('div');
const target = document.createElement('div');
const onLanguageChangeMock = jest.fn();

const form = new OpenForm(formRoot, {
baseUrl: BASE_URL,
basePath: '',
formId: '81a22589-abce-4147-a2a3-62e9a56685aa',
languageSelectorTarget: target,
lang: 'nl',
onLanguageChange: onLanguageChangeMock,
});

await act(async () => await form.init());

// wait for the loader to be removed when all network requests have completed
await waitForElementToBeRemoved(() => within(formRoot).getByRole('status'));
expect(target).not.toBeEmptyDOMElement();

await act(async () => {
await form.onLanguageChangeDone('en');
});

expect(onLanguageChangeMock).toBeCalledWith('en');
});

it('should correctly set the formUrl', () => {
mswServer.use(...apiMocks);
const formRoot = document.createElement('div');
Expand Down