-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: generate crd docs #448
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #448 +/- ##
=======================================
Coverage 78.38% 78.38%
=======================================
Files 21 21
Lines 1346 1346
=======================================
Hits 1055 1055
Misses 251 251
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. |
thisthat
reviewed
Apr 6, 2023
General suggestion - let's update the Contribution guide [1] to highlight the need of [1] - https://github.com/open-feature/open-feature-operator/blob/main/CONTRIBUTING.md |
Signed-off-by: realanna <[email protected]> ci: typo Signed-off-by: realanna <[email protected]> ci: typo Signed-off-by: realanna <[email protected]> ci: cleanup copypasta Signed-off-by: realanna <[email protected]> ci: cleanup copypasta Signed-off-by: realanna <[email protected]> ci: cleanup copypasta Signed-off-by: realanna <[email protected]> ci: generate crd Signed-off-by: realanna <[email protected]> ci: generate crd Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
RealAnna
force-pushed
the
ci/document_crd
branch
from
April 7, 2023 10:50
ffd100b
to
32e925c
Compare
Signed-off-by: realanna <[email protected]>
Signed-off-by: realanna <[email protected]>
Kavindu-Dodan
approved these changes
Apr 10, 2023
mowies
approved these changes
Apr 11, 2023
james-milligan
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
see generated docs here
Related Issues
Fixes #392