Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Replace Moq with NSubstitute #142

Merged
merged 1 commit into from
Aug 15, 2023
Merged

test: Replace Moq with NSubstitute #142

merged 1 commit into from
Aug 15, 2023

Conversation

askpt
Copy link
Member

@askpt askpt commented Aug 15, 2023

This PR

  • Replaces Moq with NSubstitute for When_Error_Occurs_In_Before_Hook_Should_Return_Default_Value test

Related Issues

Fixes #140

Notes

I am trying to figure out the sequence for the tests there are still missing. See #140 for more details

Follow-up Tasks

Missing only:

Hook_Hints_May_Be_Optional
When_Error_Occurs_In_After_Hook_Should_Invoke_Error_Hook

How to test

CI should pass :)

@askpt askpt requested a review from a team as a code owner August 15, 2023 14:50
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #142 (4e386de) into main (311987f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #142   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          20       20           
  Lines         542      542           
  Branches       39       39           
=======================================
  Hits          509      509           
  Misses         20       20           
  Partials       13       13           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@toddbaert toddbaert merged commit e9858d9 into open-feature:main Aug 15, 2023
11 checks passed
@askpt askpt deleted the askpt/140-fix_tests branch August 15, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Moq dependency with a different Mocking library
2 participants