Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add clear filter btn to filter widget #47

Conversation

yusuf-musleh
Copy link

Description

This PR adds the ability to clear a specific filter through a "Clear Filter" button in the widget, leaving the applied filters in other widgets unchanged.

Screenshot 2024-07-03 at 5 23 13 PM

Supporting Information

Testing Instructions

  1. Run this branch in your local env
  2. Navigate to a Content Library you already have (make sure you have a few components in that Content Library, ideally in different types)
  3. Make sure you have some tags applied to those components
  4. Confirm that the "Filter Tags" buttons appears at the bottom of the dropdown after applying a filter (similar to screenshot above)
  5. Confirm that clearing filters in one widget does not clear the applied filters in the other widget

Private-ref: FAL-3763

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.65%. Comparing base (dfd3190) to head (3400f71).

Additional details and impacted files
@@                                  Coverage Diff                                  @@
##           rpenido/fal-3764-library-home-filter-by-content-type      #47   +/-   ##
=====================================================================================
  Coverage                                                 92.65%   92.65%           
=====================================================================================
  Files                                                       696      696           
  Lines                                                     12365    12365           
  Branches                                                   2706     2707    +1     
=====================================================================================
  Hits                                                      11457    11457           
  Misses                                                      876      876           
  Partials                                                     32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusuf-musleh yusuf-musleh marked this pull request as ready for review July 3, 2024 15:41
Copy link
Member

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yusuf-musleh! This is looking good to me. 👍
Let me know if it is ready to merge!

@yusuf-musleh
Copy link
Author

@rpenido Great! Yes, it should be good to merge.

@rpenido rpenido merged commit 3400f71 into rpenido/fal-3764-library-home-filter-by-content-type Jul 4, 2024
5 checks passed
@bradenmacdonald bradenmacdonald deleted the yusuf-musleh/add-clear-filters-to-widget branch July 23, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants