feat: create library form (TEMP) #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When lib mode is set to "mixed", both "Libraries" and "Legacy Libraries" tabs are show in the Studio Home. When "Libraries" is clicked, v2 libraries are fetched, when "Legacy Libraries" is clicked, v1 libraries are fetched. When lib mode is set to "v1 only" or "v2 only", only one tab "Libraries" is show and only the respective libraries are fetched when the tab is clicked.
This is to switch between different library modes.
The path updates when selecting tabs, when accessing the url with the path directly it will open its respective tab. Navigating using the browser back/forward buttons is also supported.
This commit is temporary as the current frontend build system in tests doesnt support TS syntax. That should be fixed soon, and this commit should be removed.
This is a temporary commit since there are currently no webpack loaders that support tsx files in the test running. This commit should be removed once that is fixed upstream.
When lib mode is set to "mixed", both "Libraries" and "Legacy Libraries" tabs are show in the Studio Home. When "Libraries" is clicked, v2 libraries are fetched, when "Legacy Libraries" is clicked, v1 libraries are fetched. When lib mode is set to "v1 only" or "v2 only", only one tab "Libraries" is show and only the respective libraries are fetched when the tab is clicked.
This is to switch between different library modes.
The path updates when selecting tabs, when accessing the url with the path directly it will open its respective tab. Navigating using the browser back/forward buttons is also supported.
This commit is temporary as the current frontend build system in tests doesnt support TS syntax. That should be fixed soon, and this commit should be removed.
This is a temporary commit since there are currently no webpack loaders that support tsx files in the test running. This commit should be removed once that is fixed upstream.
…753-library-home-page-bare-bones
…nido/fal-3768-create-new-library-form
rpenido
force-pushed
the
rpenido/fal-3753-library-home-page-bare-bones
branch
from
ca33c18
to
6acee0a
Compare
* fix(deps): update dependency @openedx/paragon to v22.6.1 * fix: lint errors from stricter types in new paragon version --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…nido/fal-3768-create-new-library-form
| const intl = useIntl(); | ||
| const navigate = useNavigate(); | ||
|
|
||
| const [apiError, setApiError] = useState<React.ReactNode>(); |
There was a problem hiding this comment.
You don't need to create your own apiError state. When you call useCreateLibraryV2() below, it returns an error and isError state variables that you can use. It also returns an isLoading which you can use to disable the UI and display a spinner while the API call happens. See https://tanstack.com/query/v4/docs/framework/react/reference/useMutation
There was a problem hiding this comment.
Thank you @bradenmacdonald!
Didn't think this way the first time. I liked it: 9a23204
rpenido
force-pushed
the
rpenido/fal-3768-create-new-library-form
branch
from
4d9da7f
to
63e7593
Compare
Co-authored-by: Hunia Fatima <[email protected]>
…nido/fal-3768-create-new-library-form
|
Closed in favor of openedx#1116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a Create Library form to course-authoring.
More Info
Testing Instructions
Private ref: FAL-3768