fix: taxonomy card click

open-craft · Oct 25, 2023 · 591604c · 591604c
1 parent 9873871
commit 591604c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 9 deletions.
diff --git a/src/taxonomy/taxonomy-card/TaxonomyCard.jsx b/src/taxonomy/taxonomy-card/TaxonomyCard.jsx
@@ -103,8 +103,13 @@ const TaxonomyCard = ({ className, original, intl }) => {
 
   return (
     <>
-      <Card isClickable className={classNames('taxonomy-card', className)} data-testid={`taxonomy-card-${id}`}>
-        <Link className="stretched-link" to={`${id}`} aria-label="view taxonomy details" />
+      <Card
+        isClickable
+        as={Link}
+        to={`${id}`}
+        className={classNames('taxonomy-card', className)}
+        data-testid={`taxonomy-card-${id}`}
+      >
         <Card.Header
           title={name}
           subtitle={getHeaderSubtitle()}

diff --git a/src/taxonomy/taxonomy-card/TaxonomyCard.scss b/src/taxonomy/taxonomy-card/TaxonomyCard.scss
@@ -30,11 +30,6 @@
     white-space: nowrap;
   }
 
-  .pgn__card-header-actions, .badge {
-    z-index: 100; 
-    position: relative;
-  }
-
   .taxonomy-menu-item:focus {
     /**
      * There is a bug in the menu that auto focus the first item.

diff --git a/src/taxonomy/taxonomy-card/TaxonomyCardMenu.jsx b/src/taxonomy/taxonomy-card/TaxonomyCardMenu.jsx
@@ -25,9 +25,11 @@ const TaxonomyCardMenu = ({
   return (
     <>
       <IconButton
-        className="streched-link"
         variant="primary"
-        onClick={() => setMenuIsOpen(true)}
+        onClick={(e) => {
+          e.preventDefault();
+          setMenuIsOpen(true);
+        }}
         ref={setMenuTarget}
         src={MoreVert}
         iconAs={Icon}