Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: port code drift to quince #9

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

kaustavb12
Copy link
Member

@kaustavb12 kaustavb12 commented Apr 14, 2024

Description

Cherry-pick of the following commits which did not make it to upstream Quince release:

Commit Id Commit Title Upstream PR Ticket
78722f3 feat: implement SHOW_REGISTRATION_LINKS setting openedx#1066 BB-7843
abad25c feat: redirect to custom URL when third-party auth account is unlinked openedx#1078 BB-7742

OpenCraft Internal Ticket : BB-8369

Testing

This branch is deployed to this sandbox

  1. Make sure "Registration" tab is missing from the authn MFE
  2. Login using cognito using the credentials testuser : testuser. The authn MFE should redirect to a third party url due to unlinked cognito account

@kaustavb12 kaustavb12 force-pushed the kaustav/port_code_drift_quince branch from da55ddd to 8dd8889 Compare April 14, 2024 15:58
Copy link
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • ✅ I tested this on sandbox and it works fine
  • ✅ I read through the code
  • ❌ I checked for accessibility issues
  • ❌ Includes documentation
  • ❌ I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@kaustavb12 kaustavb12 changed the title Kaustav/port code drift quince chore: port code drift to quince Apr 15, 2024
@kaustavb12 kaustavb12 merged commit c2a6149 into opencraft-release/quince.1 Apr 15, 2024
4 checks passed
@kaustavb12 kaustavb12 deleted the kaustav/port_code_drift_quince branch April 15, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants