Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-schema: Clarify descriptions for Award.value and Contract.value #1656

Merged
merged 5 commits into from
Nov 13, 2023

Conversation

@duncandewhurst duncandewhurst marked this pull request as ready for review October 23, 2023 22:37
Copy link
Contributor

@odscjen odscjen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes to reflect the direction of discussion in https://docs.google.com/spreadsheets/d/1WaN5cdU5UxoCMkq8Od5zlLj68-ckn1lnzWpt_DfzqHk/edit#gid=0 about how most fields use the pattern "The of the " rather than "The of this ".

schema/dereferenced-release-schema.json Outdated Show resolved Hide resolved
schema/dereferenced-release-schema.json Outdated Show resolved Hide resolved
schema/dereferenced-release-schema.json Outdated Show resolved Hide resolved
schema/dereferenced-release-schema.json Outdated Show resolved Hide resolved
schema/release-schema.json Outdated Show resolved Hide resolved
schema/release-schema.json Outdated Show resolved Hide resolved
@jpmckinney jpmckinney merged commit e3ac1df into 1.2-dev Nov 13, 2023
10 checks passed
@jpmckinney jpmckinney deleted the 1534-value-descriptions branch November 13, 2023 20:47
@jpmckinney jpmckinney added this to the 1.2.0 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Consider adding time-based fields to preserve the values of important fields in a compiled release
3 participants