-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add planning final status fields and codelist #1642
Conversation
duncandewhurst
commented
Oct 9, 2023
•
edited
Loading
edited
- Closes Planning final status codelist #1583
- Related to Date of final state change #1582
The spell-check failure is addressed by #1641 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reading of #1582 and the associated CRM issue is that it's not just the planning final status date that's needed by also a tender.finalStatusDate
Co-authored-by: odscjen <[email protected]>
Ah, good spot. I shouldn't have marked #1582 as being closed by this PR. I figure it makes sense to do those other final status date fields when adding the new final status fields in #1160. Alternatively, we could do all of the final status and final status date fields in this PR. @jpmckinney let me know what you prefer. |
My comment in #1583 was to close it "After #1160 and #1582". #1583 is more like a new feature, whereas #1160 is a major change (#1582 is also more like a new feature). The major change should lead, before related features are implemented. I prefer to close #1160 on its own. #1582 and #1583 could potentially be combined. |
@duncandewhurst This is now unblocked. |
I think this is ready for review, unless I missed something. |
…atusDetails. Remove object name from field names. Order array fields last.
f9b3138
to
f42dd58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I aligned 'cancelled' with all other 'cancelled' in other codelists (basically, it's a decision by the buyer, always for the same potential reasons).
I also aligned 'unsuccesful' in terms of structure, and using a less specific example. A specific example, is e.g. a building application where residents might reject it.