-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding time-based fields to preserve the values of important fields in a compiled release #1534
Comments
Looks like there's been no further demand for these extra fields since this issue was created. I think we have three options:
I'm leaning towards 3. @jpmckinney what do you think? |
@yolile Since you added a thumbs up, what do you think? ValuesChanges in contract values are a common concern, but I think we can trust that the awarded value is almost always the initial contract value (or sum of the initial contracts' values). Unless the publisher made an error in their modelling, I don't think it's allowed to award a contract for one value and sign a contract for another value (especially a higher value). For award values, I don't know how frequently these are updated. Unless there was an error, I don't think these change. For tender values, I think these can be updated if e.g. the estimated value was corrected. I'm not aware of any use cases for tracking such changes – if a corrupt buyer wanted to overpay a friendly business, they would just set a high original estimate – they wouldn't amend it. So, I think we're fine with existing fields for values. DatesChanges in dates are less important. For tender dates, like tender values, I think these are largely expected to be corrections, and so the most recent value is the most (and, I think, only) relevant value. For award dates, like award values, I don't think these are expected to change. Perhaps a very sophisticated implementation would change the contractPeriod if e.g. there were delays in signature due to complaints. In that case, the most recent value is the most relevant value, anyway. For contract dates, this issue description covers the case where it's relevant to track the original. The main issue identified is when the contractPeriod at the time of the award is inaccurate. I think this scenario occurs infrequently enough that we don't need to add fields to cover it. Since we haven't identified any other time-based fields, I'm fine to close this issue. |
Sounds good. For contract values, a real example was discussed in #575 (comment), and we had already agreed that the award vs. contract value should work for that. But I'm wondering if we should add a worked example or similar to the documentation to make this clearer (and maybe check our data use guidance around contracts overrun/budget indicators to ensure we are also suggesting to compare awards vs. contracts for calculating them) |
For this issue, we can review the field descriptions to be sure this point is clear. We can create a new issue about an example in the guidance. |
Great. Thanks, both! |
@jpmckinney I've proposed a couple of options for clarifications to the field descriptions below (changes in italics). Let me know what you think. Option 1 I'm unsure about the change to
Option 2 This option perhaps overloads the description of
|
Hmm, good question. I think the first Contract.value is fine, though we have started using the parenthesized "(for example, ...)" instead of the Latin acronym "e.g.". For award, maybe after the first sentence:
|
That seems like a good solution to me. |
From the discussion in #914, we should consider whether to add time-based fields to preserve the values of important fields such as the dates and values of the main objects (tender, award, contract).
For example, we could add an explicit field to preserve the initial period in the signed contract. Otherwise, no option is perfect with respect to identifying changes to the contract period:
awards.contractPeriod
andcontracts.period
in a compiled release, it's not possible to determine whether the difference is due to a delay to signing the contract, or a post-signature change to the period.contracts.period.endDate
andcontracts.implementation.endDate
are equal in a compiled release, it's not possible to determine whether the contract was completed according to the original period in the signed contract, or whether the contract was amended andcontracts.period.endDate
updated.The text was updated successfully, but these errors were encountered: