add Bid.foreignSubsidyMeasures field and codelist #19
Conversation
|
the EU codes (Taken from https://op.europa.eu/en/web/eu-vocabularies/concept-scheme/-/resource?uri=http://publications.europa.eu/resource/authority/foreign-subsidy-measure-conclusion) don't match the OCDS pattern which is causing one of the test failures. I'm not sure how to fix the other assertion test failure which is about overwriting |
|
I'll handle the errors when it comes to me for review :) |
There was a problem hiding this comment.
Looks good aside from my question on the codelist descriptions.
I see that you settled on 'foreignSubsidyMeasures' rather than 'foreignSubsidyMeasuresConclusion' following the discussion in open-contracting/ocds-extensions#233.
codelists/foreignSubsidyMeasures.csv
Outdated
| @@ -0,0 +1,8 @@ | |||
| Code,Title,Description | |||
| fsr-adm-clos,"Notification submitted, administrative closure of FSR preliminary review procedure","Notification submitted, administrative closure of FSR preliminary review procedure" | |||
There was a problem hiding this comment.
Was there a reason not to use the definitions from the EU codelist for the code descriptions?
There was a problem hiding this comment.
Just because they're so long! I've updated in 5da9789 to use the EU descriptions
closes open-contracting/ocds-extensions#233