Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curriculum drafts #212

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Curriculum drafts #212

wants to merge 12 commits into from

Conversation

ionapjolive
Copy link

@ionapjolive ionapjolive commented Dec 20, 2017

Re issue #128 this is a start at what the curriculum could look using a template for lessons from Mozilla. Will need to work on better responsiveness and a better way to link to TEKS. Also, the index.html should probably be some kind of landing page but for now it is just the first lesson.

Making this pull request mainly to share progress and get feedback, and allow others to merge and/or plan additional work.

@mateoclarke
Copy link
Contributor

I got a chance to review this PR this evening. It looks great!!!

I'm wondering if it would be easier to deploy and maintain this as a separate github repo that gets linked from the homepage. The main thing we'd have to troubleshoot to merge would be how to serve your index file within the existing React.js + Webpack setup. (Something like this article explains 😝) Since these files don't use the same framework, it might just be easier to do it separately.

Are you able to serve this curriculum/ directory using npm start @ionapjolive? I could only get it to work dragging and dropping the files into browser.

This is what I see with npm start:
screen shot 2018-02-13 at 1 30 41 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants