修复重力旋转全屏 #1068
Merged
修复重力旋转全屏 #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
要不要順便改一下描述詞 重力感應不夠白話 改成自動旋轉螢幕會比較好 |
separate pr |
Him188
force-pushed
the
NieR/fix-gravity-fullscreen
branch
from
b6d4f87
to
16625f4
Compare
|
怎么 draft 了 |
|
现在的 pr 是有问题的，关闭重力感应全屏会使原来的全屏逻辑无法隐藏状态栏，需要处理好 Activity 因为屏幕方向改变而重启的问题 |
|
其实感觉全屏逻辑（重力和全屏按钮）并不需要自己隐藏状态栏，应该是在 onResume 里根据 isFullscreen 的状态来判断当前状态栏要不要隐藏 这样的话就不是重力感应全屏的问题了 |
This reverts commit 16625f4.
Him188
approved these changes
Oct 19, 2024
app/shared/src/commonMain/kotlin/ui/subject/episode/EpisodePage.kt
Outdated
Show resolved
Hide resolved
Him188
approved these changes
Oct 20, 2024
StageGuard
pushed a commit
that referenced
this pull request
Oct 22, 2024
* fix ScreenRotationEffect * Revert "fix ScreenRotationEffect" This reverts commit 16625f4. * use setSystemBarVisible * Update app/shared/src/commonMain/kotlin/ui/subject/episode/EpisodePage.kt * remove suspend * remove debug mode --------- Co-authored-by: Him188 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #686