SLUB: Fix interlibrary loans and requests #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* convert pickup location code to location name * change format "*" to "FL" for unnamed ill media formats * take json field "X_FL_renewable" into account: 0 = item is not an ill item (or ill item is not renewable at all?) 1 = not yet renewable (X_is_renewable == 0 in this case) 2 = renewable (X_is_renewable == 1 in this case) * don't set id for ill items as it doesn't point to SLUB catalog * avoid redundant entries of ill items in reservations, don't show if: status == 6 as item is also in the "hold" section and shows as reservation status == 11 or 13 as it's no longer relevant (item is returned) status == 16 as item is also in the "loans" section and shows as lent item
raphaelm
approved these changes
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0 = item is not an ill item (or ill item is not renewable at all?)
1 = not yet renewable (X_is_renewable == 0 in this case)
2 = renewable (X_is_renewable == 1 in this case)
status == 6 as item is also in the "hold" section and shows as reservation
status == 11 or 13 as it's no longer relevant (item is returned)
status == 16 as item is also in the "loans" section and shows as lent item
This PR addresses item # 6 of #595.