This repository has been archived by the owner on Oct 27, 2022. It is now read-only.
Fix nvme binary check #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check `[[ -z nvme ]]` can't ever fail, since it's checking the string and not the presence of a binary. Wrap that in $(command -v) to check for the binary.
b-dean
added a commit
to b-dean/ebs-automatic-nvme-mapping
that referenced
this pull request
Feb 9, 2021
also fix paths in `ebs-nvme-mapping.sh` this had previously been fixed in oogali#3 but it was changed before it was merged. then I tried to fix it again in oogali#8 but missed some of the digits rebased on top of @pforman-zymergen's PR oogali#13 because I want that binary check but udev needs the full paths
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check
[[ -z nvme ]]can't ever fail, since it's checking thestring and not the presence of a binary.
Wrap that in $(command -v) to check for the binary.