feat(keybindings): execute keybinding starting with : as ex command

[glennsl]

A simple change that allows keybindings to invoke ex commands directly, and could address quite a few of the requests in #1423. The downside of doing this instead of implementing proper commands is of course that they won't be discoverable through the command palette, but this doesn't prevent proper commands to be added either, so I think it might be a nice convenient stop-gap solution to unblock people at least.

Example:

  {key: "kk", command: ":split", when: "editorTextFocus"}

Let me know if you think this is a viable approach @bryphe, then I'll add a few integration tests before it's merged.

Fixes #807

[bryphe]

Thanks for implementing this, @glennsl ! Approach looks great to me.

I think it might be a nice convenient stop-gap solution to unblock people at least.

I agree - and definitely fits in to the 0.6.0 milestone work. 👍

This fixes #807 as well

[glennsl]

Oh wow, exactly what you proposed. And here I was thinking I had novel ideas! Probably had that one stored away in the subconscious somewhere :D I'll add some integration tests then.

[glennsl]

I'm unfortunately not able to run any integration tests locally because I get a sanitation error:

==63020==ERROR: AddressSanitizer failed to deallocate 0x2000 (8192) bytes at address 0x6250001e0100
==63020==AddressSanitizer CHECK failed: /build/gcc/src/gcc/libsanitizer/sanitizer_common/sanitizer_posix.cpp:61 "(("unable to unmap" && 0)) != (0)" (0x0, 0x0)

So I'm just pushing and hoping they'll work...

[glennsl]

/azp run

[glennsl]

/azp run

[glennsl]

/azp run

[glennsl]

/azp run

[glennsl]

CI is being very difficult, but it's just Validate Windows Release that times out now.

[bryphe]

Thanks for adding those tests, @glennsl - sorry about the CI difficulties. I bumped the Windows machine and it's green now. Looks great!

[bryphe]

Oh, and with license key bounty - this would definitely be a qualifier for it. LMK if you want an extra license key, @glennsl

[glennsl]

Thanks! But no need to worry about bounties on my account 🙂