Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] rollback boxo to 0.17 #5822

Merged
merged 2 commits into from
May 1, 2024
Merged

Conversation

peterargue
Copy link
Contributor

We're using a forked version anyway, so this doesn't change the actually run version.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

go.mod Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.67%. Comparing base (cb89118) to head (cef040a).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5822      +/-   ##
==========================================
- Coverage   55.69%   55.67%   -0.03%     
==========================================
  Files        1094     1094              
  Lines       85646    85671      +25     
==========================================
- Hits        47704    47697       -7     
- Misses      33328    33353      +25     
- Partials     4614     4621       +7     
Flag Coverage Δ
unittests 55.67% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent
Copy link
Member

turbolent commented May 1, 2024

Please also roll back the changes in insecure and integration. I've already made the relevant changes in #5820, we can port the changes over to master here.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@peterargue peterargue enabled auto-merge May 1, 2024 13:11
@peterargue peterargue added this pull request to the merge queue May 1, 2024
Merged via the queue into master with commit f7d9a07 May 1, 2024
55 checks passed
@peterargue peterargue deleted the petera/rollback-boxo-v0.17 branch May 1, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants