Merge pull request #560 from onflow/fix-format-for-block-traces-v2

Fix error handling for transaction traces
onflow · Sep 19, 2024 · 78467d5 · 78467d5
2 parents d399673 + 043c06e
commit 78467d5
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/api/debug.go b/api/debug.go
@@ -65,8 +65,9 @@ func (d *DebugAPI) TraceBlockByNumber(
 		txTrace, err := d.TraceTransaction(ctx, h, nil)
 		if err != nil {
 			results[i] = &txTraceResult{TxHash: h, Error: err.Error()}
+		} else {
+			results[i] = &txTraceResult{TxHash: h, Result: txTrace}
 		}
-		results[i] = &txTraceResult{TxHash: h, Result: txTrace}
 	}
 
 	return results, nil
@@ -87,8 +88,9 @@ func (d *DebugAPI) TraceBlockByHash(
 		txTrace, err := d.TraceTransaction(ctx, h, nil)
 		if err != nil {
 			results[i] = &txTraceResult{TxHash: h, Error: err.Error()}
+		} else {
+			results[i] = &txTraceResult{TxHash: h, Result: txTrace}
 		}
-		results[i] = &txTraceResult{TxHash: h, Result: txTrace}
 	}
 
 	return results, nil