-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
staging contract CLI #1393
staging contract CLI #1393
Conversation
…into ianthpun/stage-contract
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature/stable-cadence #1393 +/- ##
==========================================================
+ Coverage 40.60% 41.87% +1.27%
==========================================================
Files 47 53 +6
Lines 2596 2746 +150
==========================================================
+ Hits 1054 1150 +96
- Misses 1417 1447 +30
- Partials 125 149 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
works for me, i'll get those moved over and have you take a look at it. Originally we considered having it there in the first place but due to time i just had it in the CLI. But i can get something out for it by EOD |
I am heading afk for a week. So if you are on the clock just leave it. |
@bthaile @bjartek I've created onflow/flowkit#13 which would move those methods over there. Let me know what you think, if it looks good i can merge, release, and have this package use it |
f28c213
to
deeb9dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing commands against Testnet LGTM, great work!
fixed bjarteks issues, but he is gone for the week. The helper funcs are addressed inside flowkit/v2 but currently have dependency issues, will come back to this after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Have some nits mostly arround improving some of the test coverage.
}, nil) | ||
|
||
srv.ExecuteScript.Run(func(args mock.Arguments) { | ||
script := args.Get(1).(flowkit.Script) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo we should be asserting that ExecuteScript was called with the correct CDC script
Closes #1387 #1386 #1397 #1398 #1399
Description
create function commands for
getStagedCode
isStaged
listStagedContracts
StageContract
UnstageContract
include unit tests for each to test working behavior
For contributor use:
master
branchFiles changed
in the Github PR explorer