Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CCF CDDL for IntersectionType to match CCF codec #3640

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

fxamacker
Copy link
Member

This updates CCF-related comments that use CDDL notation to make them match the CCF codec implementation.

This was identified while updating CCF Specs 1.0-RC3 to 1.0.0 at onflow/ccf:


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

This updates CCF-related comments using CDDL notation
to make them match the CCF codec implementation.
@fxamacker fxamacker added the Documentation Improvements or additions to documentation label Oct 23, 2024
@fxamacker fxamacker self-assigned this Oct 23, 2024
Copy link

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 8b27276
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@turbolent
Copy link
Member

Good catch!

@fxamacker fxamacker merged commit 3815ec4 into master Oct 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants