Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support expressions in string template #3625

Conversation

RZhang05
Copy link
Contributor

Working towards #3579

Description

This PR extends the work in #3585, as planned to support expressions.


  • Targeted PR against feature/string-templates branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature/string-templates@a185a42). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             feature/string-templates    #3625   +/-   ##
===========================================================
  Coverage                            ?   80.18%           
===========================================================
  Files                               ?      412           
  Lines                               ?    95839           
  Branches                            ?        0           
===========================================================
  Hits                                ?    76850           
  Misses                              ?    16291           
  Partials                            ?     2698           
Flag Coverage Δ
unittests 80.18% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SupunS SupunS self-assigned this Oct 23, 2024
@SupunS SupunS added the Feature label Oct 23, 2024
@SupunS SupunS deleted the branch onflow:feature/string-templates October 24, 2024 18:40
@SupunS SupunS closed this Oct 24, 2024
Merge `string-templates` branch to `master`
@SupunS SupunS reopened this Oct 30, 2024
@SupunS
Copy link
Member

SupunS commented Oct 30, 2024

Didn't realize this got accidentally closed as well, with the removal of the base branch. Apologies for that!

Now that feature/string-templates branch got merged to master (#3660), @RZhang05 can you rebase this against the master branch?

@SupunS SupunS changed the title Expression string template Support expressions in string template Oct 30, 2024
@turbolent turbolent deleted the branch onflow:feature/string-templates October 30, 2024 21:12
@turbolent turbolent closed this Oct 30, 2024
@SupunS
Copy link
Member

SupunS commented Oct 30, 2024

haha, this keeps getting closed (unintentionally) 😄

Seems it's not possible to reopen/change-base without reviving the removed branch. Maybe open a new PR from the same existing branch targeting master. Or if that doesn't work, cherry-pick the commits and open a new PR.

Sorry about the extra work.

@turbolent
Copy link
Member

Argh, sorry, my bad! I thought all work related to string interpolation was complete, I didn't realize there was another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants