I have implemented the ASCII art images class

[mdtrooper]

Hi.

I have been working to add the ASCII art images class.

The main work is not mine, it is from (jsAscii 0.1

• Copyright (c) 2008 Jacob Seidelin, [email protected], http://blog.nihilogic.dk/).

But I have added blit functions and rewrote some parts for to make "rot.js standar".

Regards.

[ondras]

Hi,

*) do you have some publicly viewable demo of this?

*) What exactly does this feature do? Is it generally useful for roguelike games? I am not 100% convinced this is highly relevant to rot.js, although the feature itself sounds interesting.

*) Instead of a new "test.html" page, it might be better to use a standardized place - the interactive manual - to both showcase and document the feature (without jQuery, naturally).

*) This pullrequest cannot be automatically merged as it cretes conflicts.

[mdtrooper]

Hi.

1. Yes, I forget to upload a example (you can see in example directory).

2. I think that it is good for example the titles and some things that ASCII intros (as Dwarft Fortress intro) or for example if somebody want to implement a combat by turns similar to final fantasy games.

3. Ok. Where do you want the files?

4. Ok. I want to help you. And I can make more easy the merge. Do you want to try to merge your fork into the mine? I make this thing in other project (for example https://github.com/mdtrooper/games/network)

Regards.

[twpage]

This looks "interesting" but I don't think it fits with rot.js. Better for rot.js to focus on roguelike-specific mechanics.

[mdtrooper]

@twpage

• http://waltorious.files.wordpress.com/2011/11/doomrl-demon.jpg
• http://www.mobygames.com/images/shots/l/189815-doom-the-roguelike-dos-screenshot-myself-in-ascii-s.png

[twpage]

@mdtrooper Thanks for the examples. I actually love DoomRL, I just don't want to see the scope of rot.js expand into something too huge. As it is now it is very targeted specifically on roguelike mechanics, which is a great help for roguelike developers. Certainly nothing is stopping anyone from using a js implementation of this ASCII art converter in their game, but that doesn't mean it should be crammed into rot.js.

[mdtrooper]

It is only 4kb, but maybe I could work in the code for to slim.

[twpage]

@mdtrooper Size isn't the issue, it's scope. It's up to @ondras though, obviously. Just sharing my opinion on the internet.

[mdtrooper]

Yes of course.

[ondras]

I mostly agree with @twpage; while the feature itself is cool (I really love ASCII art!), I am not sure it really fits into rot.js's usage scope.

Let me recap this: the main use case of the discussed code is

1. take a normal HTML picture as an input,

2. convert it to an array of coloured characters.

Right? Am I not missing anything?

In a typical development scenario, a (roguelike) developer is almost certainly going to pre-convert his image data into ASCII for some breathtaking intros or so, moving the usage of this code to a development phase. This being said, I actually see the conversion more as a (web) service than a code that forms a part of a rot.js (runtime).

[mdtrooper]

Hi.

Well, yes and not, the images are from the server.

But I think that the advantage of generation the ASCII from images in the library is that you can update more easy the ASCII art across the source image.

Regards.