Skip to content

Commit

Permalink
Code clean up
Browse files Browse the repository at this point in the history
  • Loading branch information
ndegwamartin committed Sep 18, 2024
1 parent ef0fa63 commit 0ab0055
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 18 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/library.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,6 @@ jobs:
api-level: 34
script: ./gradlew :library:connectedDebug --stacktrace --info

- name: Run unit tests with Gradle
run: ./gradlew :library:clean :library:testDebugUnitTest --stacktrace
- name: Generate & upload library snapshot artifact AAR (Android Archive) file
run: ./gradlew :library:clean --stacktrace && ./gradlew :library:assembleRelease --stacktrace && ./gradlew :library:publishMavenJavaPublicationToMavenCentralRepository --stacktrace

Expand Down
4 changes: 2 additions & 2 deletions library/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ buildscript {
apply plugin: 'realm-android'
apply plugin: 'maven-publish'

version '0.10.6-SNAPSHOT'
version '0.10.6-2-SNAPSHOT'

project.version = this.version

Expand Down Expand Up @@ -123,7 +123,7 @@ dependencies { configuration ->
//implementation (project(":utils")) {
// Uncomment the line below when creating releases
implementation('io.ona.kujaku:utils:0.10.6-SNAPSHOT') {
transitive = true;
transitive = true
exclude group: 'com.mapbox.mapboxsdk', module: 'mapbox-android-sdk'
exclude group: 'com.android.support', module: 'support-v4'
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,6 @@
import static org.junit.Assert.fail;
import static org.mockito.Mockito.mock;

/**
*
*
* Created by Ephraim Kigamba - [email protected] on 05/12/2017.
*/
@RunWith(RobolectricTestRunner.class)
@Config(manifest = Config.NONE,
shadows = {
Expand All @@ -83,23 +78,23 @@
})
public class MapboxOfflineDownloaderServiceTest {

private String mapName = UUID.randomUUID().toString();
private final String mapName = UUID.randomUUID().toString();
private static final String TAG = MapboxOfflineDownloaderServiceTest.class.getSimpleName();

private Context context;
private MapboxOfflineDownloaderService mapboxOfflineDownloaderService;

private String sampleValidMapboxStyleURL = "mapbox://styles/ona/90kiosdcIJ3d";
private final String sampleValidMapboxStyleURL = "mapbox://styles/ona/90kiosdcIJ3d";
private String mapboxAccessToken;
private float minZoom = 22;
private float maxZoom = 10;
private LatLng topLeftBound = new LatLng(9.1, 9.1);
private LatLng topRightBound = new LatLng(9.1, 20.5);
private LatLng bottomRightBound = new LatLng(1.1, 20.5);
private LatLng bottomLeftBound = new LatLng(9.1, 1.1);
private final float minZoom = 22;
private final float maxZoom = 10;
private final LatLng topLeftBound = new LatLng(9.1, 9.1);
private final LatLng topRightBound = new LatLng(9.1, 20.5);
private final LatLng bottomRightBound = new LatLng(1.1, 20.5);
private final LatLng bottomLeftBound = new LatLng(9.1, 1.1);

private CountDownLatch latch;
private ArrayList<Object> resultsToCheck = new ArrayList<>();
private final ArrayList<Object> resultsToCheck = new ArrayList<>();

@Before
public void setUp() throws Exception {
Expand Down

0 comments on commit 0ab0055

Please sign in to comment.