Add token request parameters for authorization code flow #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coberlin
force-pushed
the
add-extra-token-request-params
branch
from
c533a1a
to
38e5959
Compare
|
Update: Changing request to require redirect_uri -- it is required, not optional, per https://docs.duendesoftware.com/identityserver/v7/reference/endpoints/token/ |
The access token request needs the code if we're using code flow. For authorization code flow, grant_type and redirect_uri are also required. See https://docs.duendesoftware.com/identityserver/v7/reference/endpoints/token/ To run tests, pin the minitest version per a conflict with mocha, as noted here: freerange/mocha#614 But do not leave pinned as the gem fails to install under some rubies that previously succeeded. For example: net-imap-0.5.0 requires ruby version >= 3.1.0, which is incompatible with the current version, ruby 2.6.8p0 (jruby 9.3.7.0)
coberlin
force-pushed
the
add-extra-token-request-params
branch
from
38e5959
to
42df4f4
Compare
|
Update: Changing request to require redirect_uri -- it is required, not optional, per https://docs.duendesoftware.com/identityserver/v7/reference/endpoints/token/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The access token request needs the code if we're using code flow. Some providers require additional parameters such as grant_type and redirect_uri.
To run tests, pin the minitest version per a conflict with mocha, as noted here: freerange/mocha#614
But do not leave pinned as the gem fails to install under some rubies that previously succeeded.
For example:
net-imap-0.5.0 requires ruby version >= 3.1.0, which is incompatible with the current version, ruby 2.6.8p0 (jruby 9.3.7.0)
Also, Set grant type explicitly when response type is code
Setting the grant_type to :authorization_code in extra_token_params results in token requests with multiple grant types separated by commas, with authorization_code appended to the end, which results in invalid grant type error from the provider.